scipp / essreflectometry

Reflectometry data reduction for the European Spallation Source
https://scipp.github.io/essreflectometry/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Amor reduction: Normalization should be performed in coordinates that don't depend on the instrument settings #41

Closed jokasimr closed 1 month ago

jokasimr commented 3 months ago

Currently the reference is reduced to $Q$ before it's applied to normalize the counts from the sample. This is not correct, because what $\lambda$ and what detector pixels contribute to a particular $Q$-bin depends on the instrument settings of the run (the sample inclination $\mu$). So if the reference measurement is particularly weak for one $Q$ because there are weak pixels contributing to that $Q$, that doesn't mean the sample measurement is weak for that $Q$ because the weak pixels might contribute to a different $Q$ in that run.

The solution (if I understand it correctly, perhaps double check with Jochen) is to reduce the sample and reference measurement(s) to coordinates that don't depend on the instrument settings, those could be $\lambda$ and $y$ (note that Jochen calls this $z$), and normalize there before binning in $Q$.

nvaytet commented 1 month ago

@jokasimr will this be fixed by #44 ?

jokasimr commented 1 month ago

Yes