This is not really ready to merge yet but I have some questions so I'll ask for review anyway.
Outstanding issues:
Some procedures have several optional arguments with default values, see supermirror_calibration and make_beamline. How should we deal with those parameters?
If we make each parameter into a provider that is going to clutter the graph visualization.
We could pass them as parameters to the pipeline. But how can we make them default parameters of the pipeline?
Orso
There's a separation between the Amor specific providers and generic reflectometry providers. Currently all domain types are defined in reflectometry.types but it would be better to specify the Amor specific types separately. How can this be done in a good way?
Consider for example the situation where reflectometry defines two nodes, A->B and the Amor workflow wants to place a step C in between them: A->C->B.
jokasimr
commented
8 months ago
This is not really ready to merge yet but I have some questions so I'll ask for review anyway.
Outstanding issues:
supermirror_calibrationandmake_beamline. How should we deal with those parameters?reflectometry.typesbut it would be better to specify the Amor specific types separately. How can this be done in a good way?