scipp / essreflectometry

Reflectometry data reduction for the European Spallation Source
https://scipp.github.io/essreflectometry/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Re-run comparison to PSI + some minor fixes #67

Closed jokasimr closed 1 month ago

jokasimr commented 1 month ago

I was looking at resolving the discrepancy in the result compared to PSI and as part of that I re-ran the Jochens Amor code to re-create the reference files that I was comparing against.

Surprisingly the results are now much closer. There are two possible reasons:

In any case, I uploaded the new reference files to our file-server.

jokasimr commented 1 month ago

Comparison between the old and the new results:

Old results

user-guide_amor_compare-to-eos-old

New results

user-guide_amor_compare-to-eos-new

It's now only file 611 that has a real discrepancy. Still unclear why. Hopefully this insight will make the issue easier to debug. (Changing the sample rotation for 611 to 4.95 makes the curves overlap, might give a clue to understand what's going on.)

jokasimr commented 1 month ago

This is the commit that seems to have been the cause of the change: https://github.com/jochenstahn/amor/commit/140e3192ddb7e7f28acee87e2acaee65ce1332aa