search

scipp / esssans

SANS data reduction for the European Spallation Source
https://scipp.github.io/esssans/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Use essreduce loaders #114

Closed nvaytet closed 8 months ago

nvaytet commented 8 months ago

Fixes #112

Note: CI is failing because essreduce does not exist as a package yet

EDIT by JL: Also fixes #106, #109, #110

Note: We have changed the place where we merge events from multiple files in the workflow. We used to merge the events early, into a single data array. This meant we had to make sure that sample and detector positions were the same for all runs. Now we compute Q and wavelength for numerator and denominator for each file, and merge just before normalization.

jl-wynen commented 8 months ago

@nvaytet Can you target the PR on the namespace pkg branch? Then the diff only shows the relevant changes. Merging that branch will retarget the PR automatically onto main.

nvaytet commented 8 months ago

@jl-wynen I forgot to remove the old loaders...

jl-wynen commented 8 months ago

ESSreduce has been released