scipp / esssans

SANS data reduction for the European Spallation Source
https://scipp.github.io/esssans/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Monitor wavelength binning workflow example. #134

Closed YooSunYoung closed 6 months ago

YooSunYoung commented 7 months ago

Fixes scipp/beamlime#186

YooSunYoung commented 7 months ago

@SimonHeybrock Will you check if it's in the right direction...?

YooSunYoung commented 7 months ago

This is what I tried to make:

workflow

YooSunYoung commented 7 months ago

I put the IofQ back.

stateless_workflow

YooSunYoung commented 7 months ago

Since the workflow accepts JsonGroup, how should they be tested...? Is there any tools to convert NexusGroup into JsonGroup...?

YooSunYoung commented 7 months ago

Has this been tested with the latest Beamlime? Do we get data through the entire chain?

I tried but I couldn't make it work with the loki.json template. It's complaining with this error message:

ValueError: Raw data loaded from NeXus does not contain events or a histogram. Expected to find a data array, but the data only contains {'depends_on', 'name', 'transformations', 'transform', 'monitor_2_events', 'position'}

That's why I asked this:

Since the workflow accepts JsonGroup, how should they be tested...? Is there any tools to convert NexusGroup into JsonGroup...?

YooSunYoung commented 7 months ago

Has this been tested with the latest Beamlime? Do we get data through the entire chain?

The minitor workflow works with the fixes that I mentioned here: https://github.com/scipp/beamlime/issues/193

The fixes are stashed in this branch: https://github.com/scipp/beamlime/tree/atleast-work

I'll fix them in an order...

I got these plots as a result :D test-ess loki workflow MonitorHistogram ess sans types SampleRun, ess sans types Incident test-ess loki workflow MonitorHistogram ess sans types SampleRun, ess sans types Transmission