Workflow dependency restructure

scipp / esssans

SANS data reduction for the European Spallation Source

https://scipp.github.io/esssans/

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Workflow dependency restructure #155

Closed SimonHeybrock closed 3 months ago

SimonHeybrock commented 4 months ago

Fixes #154.

There are some subtleties here, around different way of handling ESS NeXus vs. Mantid files.

The I(Q) beam-center finder was a headache, but I hope by passing the workflow I managed to make it a bit more natural. There is potential room for improvement, by avoiding reloading data even if positions change, but I left it for now until we know if this actually is an issue in practice.

SimonHeybrock commented 4 months ago

Looks good to me. Tests are failing but I assume this is expected?

Yes, failing due to unreleased and unreviewed changes in ESSreduce.