scipp / esssans

SANS data reduction for the European Spallation Source
https://scipp.github.io/esssans/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Loki gets lab-frame transform for solid angle from uncalibrated detector position #174

Closed SimonHeybrock closed 1 month ago

SimonHeybrock commented 2 months ago

See https://github.com/scipp/esssans/blob/9434614cf0e2db615779c8d83e375094b059174e/src/ess/loki/general.py#L86-L90 I don't know if this was done correctly in the past and broken in some graph restructure, or if it was always wrong?

As this part of the NeXus workflow is currently being refactored in scipp/essreduce#114 I will fix it as part of those updates.