scipp / esssans

SANS data reduction for the European Spallation Source
https://scipp.github.io/esssans/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

More and better live reduction workflows #179

Closed SimonHeybrock closed 1 month ago

SimonHeybrock commented 1 month ago

This depends on a release of scipp/essreduce#118. I have not added new tests for now as this is tightly linked to Beamlime and some unrelated changes so I presume it will change, so at this point I believe too much testing would be harmful.

Fixes scipp/beamlime#162.

See also beamlime/issues/245 which describes gaps the in creation logic that I encountered while working on this. This will be resolved in future work.

YooSunYoung commented 1 month ago

I see the pakcage test fails like this:

Traceback (most recent call last):
  File "/home/runner/work/esssans/esssans/tests/package_test.py", line 3, in <module>
    from ess import isissans, loki, sans
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/ess/isissans/__init__.py", line 6, in <module>
    from . import general, io, sans2d, zoom
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/ess/isissans/general.py", line [13](https://github.com/scipp/esssans/actions/runs/11273816229/job/31351656794?pr=179#step:6:14), in <module>
    from ess.reduce.nexus.types import NeXusTransformation, Position
ImportError: cannot import name 'NeXusTransformation' from 'ess.reduce.nexus.types' (/opt/hostedtoolcache/Python/3.10.[15](https://github.com/scipp/esssans/actions/runs/11273816229/job/31351656794?pr=179#step:6:16)/x64/lib/python3.10/site-packages/ess/reduce/nexus/types.py)

Is it expected or is the test dependencies outdated...?