search

scipp / esssans

SANS data reduction for the European Spallation Source
https://scipp.github.io/esssans/
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

SANS beam center correction may need to be applied differently #28

Open SimonHeybrock opened 1 year ago

SimonHeybrock commented 1 year ago

Based on Slack discussion in #dmsc-loki:

Currently the correction is applied as a fixed shift to all pixels. However, since LoKI has banks at different Z this may be incorrect.

SimonHeybrock commented 2 months ago

There are two relevant changes since this issue was written, making this easier:

  1. We have moved to handling detector banks using Sciline's map (currently wrapped by https://scipp.github.io/esssans/generated/functions/ess.sans.with_banks.html).
  2. The beam center has to be set by hand and is not auto-computed in the workflow.

We could thus perform a joint mapping over a single table of detector banks names with their respective beam centers (which might be 0 or static for anything by the rear detector?).