Closed nvaytet closed 7 months ago
I think I had briefly tried something like this, but then we need to check or decide what to do when a dict/list with all there coords is provided. Or maybe that is what we should do, and additionally have a flag the defines which one to use?
I guess if someone supplies all 3 you may get 3 dimensions in the output? Q, Qx, Qy
.
It would be weird but consistent?
That makes little sense.
We don't support unions as params, right? So we could so something like
# for 1d Q bins
params[QBins] = QBins.q(sc.geomspace(dim='Q', start=0.004, stop=0.8, num=141, unit='1/angstrom'))
# for Qxy bins
params[QBins] = QBins.qxy(
sc.linspace(dim='Qx', start=-0.5, stop=0.5, num=101, unit='1/angstrom'),
sc.linspace(dim='Qy', start=-0.8, stop=0.8, num=101, unit='1/angstrom'),
)
Trying to find a way to make invalid states unrepresentable.
Picking this up since the removal of Optional
support in Sciline will require changes around this anyway.
Following guideline in https://github.com/scipp/ess/issues/219.
Instead, we could maybe make a single parameter? However, it may not be as user-friendly?
Currently:
Could become:
but maybe annoying to have to define a dict if we are only doing 1d Q binning?
Another suggestion was:
and just infer from the dims?