search

scipp / scippneutron

Neutron scattering toolkit built using scipp for Data Reduction. Not facility or instrument specific.
https://scipp.github.io/scippneutron/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Update for next scipp #461

Closed jl-wynen closed 12 months ago

jl-wynen commented 1 year ago

This won't build yet because it needs deprecated_attrs with has not been released.

jl-wynen commented 1 year ago

The tutorials need some work. I may have to rewrite a significant part of 'exploring data' to use data groups.

jl-wynen commented 1 year ago

Now also fixes #462

jl-wynen commented 1 year ago

I'm waiting until the scipp release before merging.

jl-wynen commented 1 year ago

I changed it to always fall back it deprecated_(attrs|meta) is not available. This should not work with scipp 23.07 and 23.08+

nvaytet commented 1 year ago

This should not work with scipp 23.07 and 23.08+

Did you mean "not work" or "now work"?

jl-wynen commented 1 year ago

This should not work with scipp 23.07 and 23.08+

Did you mean "not work" or "now work"?

I meant 'now'