search

scipp / scippneutron

Neutron scattering toolkit built using scipp for Data Reduction. Not facility or instrument specific.
https://scipp.github.io/scippneutron/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Use py 3.10 and mantid 6.8 in CI #464

Closed jl-wynen closed 10 months ago

jl-wynen commented 10 months ago

Mamba failed to resolve the env. So I took the opportunity to update the rest of our dependencies as well.

SimonHeybrock commented 10 months ago

What about 3.9? Does/should ScippNeutron still support it?

jl-wynen commented 10 months ago

What about 3.9? Does/should ScippNeutron still support it?

I'd say it should. And it does. But if we want to test it, then we need to test both with and without mantid because we have no way of running mantid tests with 3.9.

SimonHeybrock commented 10 months ago

What about 3.9? Does/should ScippNeutron still support it?

I'd say it should. And it does. But if we want to test it, then we need to test both with and without mantid because we have no way of running mantid tests with 3.9.

I fear that 1 minute after we drop 3.9 testing someone will merge something that breaks support? If we plan to drop 3.9 soon anyway then maybe we should simply make a clear decision?

jl-wynen commented 10 months ago

In scipp, we should stick to the numpy schedule, i.e., support 3.9 until next April. But downstream, we maybe can be more flexible. I don't know if we have any dependencies in ess that don't support it yet, though.

SimonHeybrock commented 10 months ago

Yes, definitely for Scipp (and any non-ESS packages (I am counting ScippNeutron as ESS-package)).

Is it much work to have CI run for 3.8 without Mantid? Are we fine with "hoping" that nothing breaks 3.8 in the next 6 months?

jl-wynen commented 10 months ago

It should run with both versions now. Pytest should automatically skip mantid tests when mantid is not installed. The main downside I see is that we have theses long running / hanging tests. So doubling the number of runs increases the risk of that happening.

jl-wynen commented 10 months ago

Actually, it's more complicated because there seems to be no easy way to filter out mantid from the buildconfig files. I can duplicate them for 3.9. This would not be a huge issue as this will be temporary. What do you think?

SimonHeybrock commented 10 months ago

I don't have strong opinions here, go with whatever you prefer.

jl-wynen commented 10 months ago

It's implemented now. So let's keep it