search

scipp / scippneutron

Neutron scattering toolkit built using scipp for Data Reduction. Not facility or instrument specific.
https://scipp.github.io/scippneutron/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Peak fitting and removal #504

Closed jl-wynen closed 3 months ago

jl-wynen commented 4 months ago

This implements a generic peak-removal routine that can be used for https://github.com/scipp/essdiffraction/issues/24

For now, I could only test this with POWGEN data as all other test data I could get either contains no peaks or peaks with a strange shape. I talked with @celinedurniak about test data fro DREAM. But it seems unclear at this point how best to test it.

I am opening this PR so that the code can be reviewed as it should not change significantly for new data.

jl-wynen commented 4 months ago

I used python 3.10 features, expecting that this would not be merged before we drop 3.9. So the CI cannot pass.

nvaytet commented 4 months ago

I have no further comments. Looks good as far as I'm concerned 👍