search

scipp / scippneutron

Neutron scattering toolkit built using scipp for Data Reduction. Not facility or instrument specific.
https://scipp.github.io/scippneutron/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Harmonize CI with other projects #506

Closed nvaytet closed 4 months ago

nvaytet commented 4 months ago

Instead of having two .yml workflows, run Mantid tests in a separate job but same workflow, and remove pr_and_main.yml workflow.

nvaytet commented 4 months ago

Could this lead to harder-to-resolve conflicts when we update the template? I don't know how it behaves when a chunk is added in the middle of a file.

I just tried a copier update from this branch and updating the ci.yml file was fine.

nvaytet commented 4 months ago

I'm not sure if we want to keep the .buildconfig files for the other platforms around? I guess they may be useful? It's just that we are not keeping them up to date.

Maybe if we do https://github.com/scipp/copier_template/issues/158, we could (partly?) generate the buildconfig files from the pyproject.toml?

jl-wynen commented 4 months ago

not sure if we want to keep the .buildconfig files for the other platforms around? I guess they may be useful? It's just that we are not keeping them up to date.

Maybe if we do scipp/copier_template#158, we could (partly?) generate the buildconfig files from the ptproject.toml?

Maybe we can generate it. But our philosophy in other packages is to only test on Linux. Since we don't interact with Mantid through C++, this should be fine here, too. So I think the files can be removed.