search

scipp / scippneutron

Neutron scattering toolkit built using scipp for Data Reduction. Not facility or instrument specific.
https://scipp.github.io/scippneutron/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Fix conda build #519

Closed jl-wynen closed 3 months ago

jl-wynen commented 3 months ago

The type hints were bad because mp.Queue is a function, not a class. This was not caught earlier because we don't run mypy and Optional[mp.Queue] is allowed. But mp.Queue | None is not allowed because the pipe operator is only implemented for types, not functions.

I added sciline as a dependency because we were skipping the frame unwrapping tests both in the package build and CI.

MridulS commented 3 months ago

(probably) relavent issue https://github.com/sphinx-doc/sphinx/issues/12300

jl-wynen commented 3 months ago

@YooSunYoung it is working now