search

scipp / scippnexus

h5py-like utility for NeXus files with seamless scipp integration
https://scipp.github.io/scippnexus/
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Load NXdetector and NXmonitor as DataGroup #172

Closed SimonHeybrock closed 8 months ago

SimonHeybrock commented 8 months ago

This avoids some conceptual problems and ambiguities. I think we might need to refine some details, e.g., some scalar datasets should probably made into coords, instead of being kept in the top-level data group.

This constitutes a breaking change for users. One could probably support both approaches side-by-side by having the old and new NXdetector and NXmonitor definitions, which can be specified when opening a file using snx.File. Should we do that, or is our user base small enough so we can move directly?

jl-wynen commented 8 months ago

Should we do that, or is our user base small enough so we can move directly?

Since the new approach would become the default, the users would need to take action immediately anyway (unless we do 2 step approach like migration to plopp). And converting the new data groups into data arrays isn't much more complicated than switching to the old definitions. Esp. because users probably are not used to application definitions.