scipp / scippnexus

h5py-like utility for NeXus files with seamless scipp integration
https://scipp.github.io/scippnexus/
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

[Fix] issue 204 by removing trailing forward slashes in string selectors #205

Closed g5t closed 5 months ago

g5t commented 5 months ago

One possible fix for #204 if any number of trailing forward slashes should not raise an error.

Fixes #204.

MridulS commented 5 months ago

The doc failure should be fixed by https://github.com/scipp/scippnexus/pull/207

g5t commented 5 months ago

I've added a unit test which will fail with a KeyError before my proposed fix. It may be more-restrictive than necessary, since it only passes the assert if the same object is returned with and without a trailing forward slash in its path.