scipp / tof

A simple tool to create time-of-flight chopper cascade diagrams
https://tof.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Add support for counter rotating choppers #47

Closed nvaytet closed 1 year ago

nvaytet commented 1 year ago

Add support for counter-rotating choppers via the direction='anticlockwise' argument.

After discussions in #44 , I decided that using a classmethod for this is not so useful because the computation of the times when the windows are open/closed are not done upon construction. They depend on how many rotations need to be performed.

I think the easiest is to have the direction argument, set to clockwise by default so that current users do not have to change all their notebooks.

We will most probably still use a classmethod to create a chopper from nexus parameters.

Supersedes #44

Fix #5