I have not resolved this by writing tests for these utils yet.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x] Targeted PR against correct branch (develop)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
alexander-zw
commented
3 years ago
Description
Should be merged before the corresponding PR in libsnark: https://github.com/scipr-lab/libsnark/pull/186. Fixes bugs that were not caught due to field utils not being tested.
I have not resolved this by writing tests for these utils yet.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer