Move each curve's field initialization into separate files so the fields can be initialized without dealing with the rest of the curve. In particular, this is useful for testing field implementations and parameters, which will be the focus of the next PR.
Change all curve files to use std::size_t. Change a few unused util functions to use ceil_size_in_bits() instead of size_in_bits(). Fix a compile error that references a deleted function bigint::operator%. Update documentation.
closes: N/A
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x ] Targeted PR against correct branch (develop)
[x ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[? ] Wrote unit tests
[x ] Updated relevant documentation in the code
[x ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x ] Re-reviewed Files changed in the Github PR explorer
Note: new new units tests necessary since no changes were made, except bigint::is_even() which will have tests added along with other util tests in a later PR.
Description
Move each curve's field initialization into separate files so the fields can be initialized without dealing with the rest of the curve. In particular, this is useful for testing field implementations and parameters, which will be the focus of the next PR.
Change all curve files to use
std::size_t
. Change a few unused util functions to useceil_size_in_bits()
instead ofsize_in_bits()
. Fix a compile error that references a deleted functionbigint::operator%
. Update documentation.closes: N/A
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerNote: new new units tests necessary since no changes were made, except
bigint::is_even()
which will have tests added along with other util tests in a later PR.