scipr-lab / libff

C++ library for Finite Fields and Elliptic Curves
Other
149 stars 82 forks source link

Move curve field initialization into separate files and use std::size_t #79

Closed alexander-zw closed 3 years ago

alexander-zw commented 3 years ago

Description

Move each curve's field initialization into separate files so the fields can be initialized without dealing with the rest of the curve. In particular, this is useful for testing field implementations and parameters, which will be the focus of the next PR.

Change all curve files to use std::size_t. Change a few unused util functions to use ceil_size_in_bits() instead of size_in_bits(). Fix a compile error that references a deleted function bigint::operator%. Update documentation.

closes: N/A


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

Note: new new units tests necessary since no changes were made, except bigint::is_even() which will have tests added along with other util tests in a later PR.