search

scipr-lab / libsnark

C++ library for zkSNARKs
Other
1.81k stars 572 forks source link

Used r1cs_auxiliary_input instead of r1cs_primary_input for consistency #123

Closed AntoineRondelet closed 6 years ago

AntoineRondelet commented 6 years ago

In the auxiliary_input() function of the gadgetlib1/protoboard.tcc file, a r1cs_primary_input object is returned in the return statement: 

return r1cs_primary_input<FieldT>(values.begin() + num_inputs(), values.end());

While r1cs_primary_input, and r1cs_auxiliary_input are basically different aliases for std::vector<FieldT>; I guess, it's better to use r1cs_auxiliary_input here to keep it consistent.