search

scipr-lab / libsnark

C++ library for zkSNARKs
Other
1.81k stars 572 forks source link

make check does not work on MacOS Mojave #140

Closed derekzx closed 5 years ago

derekzx commented 5 years ago

Facing error when running

make check
...
-ld: cannot find -lcrypto:
...
derekzx commented 5 years ago

Replace instances of

-lcrypto

with

/usr/local/opt/openssl/lib/libcrypto.dylib

for all of the link.txt files (>40) contained within /libsnark/build/libsnark/XXX_test/link.txt

derekzx commented 5 years ago

Some tests are still failing but it might a library/snark error.

stefandeml commented 5 years ago

Can reproduce the error on my machine. Try to run with the following env variables & flags set: PPFLAGS=-I/usr/local/opt/openssl/include LDFLAGS=-L/usr/local/opt/openssl/lib PKG_CONFIG_PATH=/usr/local/opt/openssl/lib/pkgconfig cmake -DWITH_PROCPS=OFF -DWITH_SUPERCOP=OFF ..

derekzx commented 5 years ago

This works: Points environment variables into openssl

LD_LIBRARY_PATH=/usr/local/opt/openssl/lib:"${LD_LIBRARY_PATH}"                    
CPATH=/usr/local/opt/openssl/include:"${CPATH}"                                    
PKG_CONFIG_PATH=/usr/local/opt/openssl/lib/pkgconfig:"${PKG_CONFIG_PATH}"          
export LD_LIBRARY_PATH CPATH PKG_CONFIG_PATH
mathcrypto commented 5 years ago

I had an issue running make check on MacOS Mojave as well. The tests fail and this is the result I get

43% tests passed, 13 tests failed out of 23

Total Test time (real) =  55.17 sec

The following tests FAILED:
      2 - gadgetlib1_simple_test (Child aborted)
      3 - gadgetlib1_r1cs_ppzksnark_verifier_gadget_test (Child aborted)
      7 - gadgetlib2_integration_test (Child aborted)
     10 - relations_qap_test (Child aborted)
     11 - relations_sap_test (Child aborted)
     12 - relations_ssp_test (Child aborted)
     13 - zk_proof_systems_bacs_ppzksnark_test (Child aborted)
     14 - zk_proof_systems_r1cs_ppzksnark_test (Child aborted)
     15 - zk_proof_systems_r1cs_se_ppzksnark_test (Child aborted)
     16 - zk_proof_systems_r1cs_gg_ppzksnark_test (Child aborted)
     17 - zk_proof_systems_ram_ppzksnark_test (Child aborted)
     18 - zk_proof_systems_tbcs_ppzksnark_test (Child aborted)
     19 - zk_proof_systems_uscs_ppzksnark_test (Child aborted)
Errors while running CTest
make[3]: *** [CMakeFiles/check] Error 8
make[2]: *** [CMakeFiles/check.dir/all] Error 2
make[1]: *** [CMakeFiles/check.dir/rule] Error 2
make: *** [check] Error 2