Increase cmake version, avoid printing debugging values (do not pull automatically!)

scipr-lab / libsnark

C++ library for zkSNARKs

Other

1.8k stars 570 forks source link

Increase cmake version, avoid printing debugging values (do not pull automatically!) #161

Open meilof opened 4 years ago

meilof commented 4 years ago

Setting version to 3.1 enables using CMAKE_PREFIX_PATH to specify pkg-config locations (see https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L115). This heps for example on Mac OS X if you want to provide a location for libcrypto. With this patch I was able to compile libsnark with

"cmake .. -DCMAKE_PREFIX_PATH=/usr/local/Cellar/openssl/1.0.2s -DWITH_PROCPS=OFF -DWITH_SUPERCOP=OFF"

meilof commented 4 years ago

Hmm, I see now you should not merge this pull request directly because it will also change the reference to libff (to a version that I also patched to remove debugging output)!