Accessed point coordinates via public attribute

scipr-lab / libsnark

C++ library for zkSNARKs

Other

1.8k stars 570 forks source link

Accessed point coordinates via public attribute #171

Closed AntoineRondelet closed 2 years ago

AntoineRondelet commented 4 years ago

This changes are related to https://github.com/scipr-lab/libff/pull/35 and this PR should be merged after the one on libff to track the changes on the master branch of libff via the submodules

AntoineRondelet commented 4 years ago

This LGTM! is merging this blocked on versioning libff/using the latest version in libsnark?

Good catch @ValarDragon I forgot to update the submodule after the proposed changes were merged in libff. I updated the libff submodule to point to https://github.com/scipr-lab/libff/commit/5835b8c59d4029249645cf551f417608c48f2770 which as of today is the "tip" of the master branch.