scipr-lab / libsnark

C++ library for zkSNARKs
Other
1.8k stars 570 forks source link

Presumably wrong value of `PI` constant #187

Open cadaniluk opened 3 years ago

cadaniluk commented 3 years ago

In libff, both common/double.cpp and algebra/fields/field_utils.tcc define the constant PI as

const double PI = 3.141592653589793238460264338328L;

But isn't the 0 wrong? As this website says, for example, it is (rounded)

3.14159265358979323846264338328