Update .gitmodules to use https urls

scipr-lab / libsnark

C++ library for zkSNARKs

Other

1.8k stars 570 forks source link

Update .gitmodules to use https urls #192

Open dark64 opened 2 years ago

dark64 commented 2 years ago

Recent changes in the Git protocol security on GitHub https://github.blog/2021-09-01-improving-git-protocol-security-github/ broke our build script that clones libsnark. I found that some submodules referenced in .gitmodules use the unencrypted git protocol and some use https, which produces an error The unauthenticated git protocol on port 9418 is no longer supported if the repository is cloned using the https protocol.

AntoineRondelet commented 2 years ago

Ah yes good catch @dark64 thanks for this. I actually updated it on https://github.com/clearmatics/libsnark/pull/37 but forgot to propagate here...

AntoineRondelet commented 2 years ago

@ValarDragon is there any plan to release a new version of libsnark at some point in the near future? If so, I think this PR should probably target staging for now and will hit master on the new release.

mkumar-cognam commented 12 months ago

we can also use git to change protocol to https using below command

git config --global url."https://".insteadOf git://