search

scipr-lab / libsnark

C++ library for zkSNARKs
Other
1.83k stars 583 forks source link

Clang Support #67

Open Maroc-OS opened 7 years ago

Maroc-OS commented 7 years ago

Why not thinking about adding Clang Support? the code is not clean enough, and have to be standardised, clang does not accept to compile it because of that.

Must of problems are "invalid operands to binary expression" because of mal-placements of templates/functions.

Clang is very powerful in case of code analysis and error reporting, and can help fining more bugs and fixing more problems and even optimizing the code.

Any Chances?

chfast commented 7 years ago

I can fix issues with clang. If done, will that be merged in?

tromer commented 7 years ago

@chfast, that would be great! But please do so on top of the cmake branch, which we plan to transition to (#65).

chfast commented 7 years ago

The cmake branch sound even better :)

Maroc-OS commented 7 years ago

i have sent a very small pr about this and i think i have some other patches.

https://github.com/zcash/libsnark/pull/12

chfast commented 7 years ago

Ok, nice. Do you plan to upstream the changes here? How much different is the zcash version?

copumpkin commented 6 years ago

I would love to see this, too

MarkLTZ commented 5 years ago

I have the same issue