search

scipr-lab / libsnark

C++ library for zkSNARKs
Other
1.81k stars 579 forks source link

Make: issue with installed headers #68

Closed chfast closed 7 years ago

chfast commented 7 years ago

make install installs headers to <prefix>/include/libsnark. By convention dependent project should include -I<prefix>/include only. However, this does not work, because libsnark headers includes other libsnark headers without libsnark prefix, e.g. https://github.com/scipr-lab/libsnark/blob/master/src/algebra/curves/alt_bn128/alt_bn128_g1.hpp#L11.

tromer commented 7 years ago

The current convention is to -I<prefix>/include/libsnark. Is there a strong reason to change that?

chfast commented 7 years ago

Not a very big deal. I included both paths, but will try to use only the mentioned one.