search

scipr-lab / libsnark

C++ library for zkSNARKs
Other
1.81k stars 579 forks source link

Ensure everything compiles individually & sort includes #79

Closed aleksejspopovs closed 7 years ago

aleksejspopovs commented 7 years ago

Just like in libff pull request 9, I have made every file in libsnark compile individually by adding all missing includes, and also sorted all includes.

I also fixed a couple of places where references to functions/variables from libff were not properly namespaced.

I also deleted libsnark/gadgetlib1/gadgets/cpu_checkers/tinyram/components/instruction_packing_gadget.{hpp,tcc}. These files did not compile, contained references to names that did not actually exist, and were not even included from anywhere. According to Madars, these files used to be a part of a previous implementation of the reduction, and don't have any purpose any more.

tromer commented 7 years ago

LGTM, and indeed needed. Let's merge.

In the future please try to break changes into separate commits (e.g., removal of instruction_packing_gadget) to ease reviewing, cherry-picking and bisection.