Build pull requests

[zonca]

@stefanv : To replace the current build bot, we'd need paper PRs to be built so that we can review them

The easiest way would be to build all of the proceedings for each pull request in their own subfolder, like:

http://scipy-conference.github.io/proceedings/2014/submission/10

[zonca]

Hit a showstopper on this, travis-ci does not set secure environment variables on pull requests, otherwise it would be easy for attackers to grab them.

So this is not feasible.

@stefanv , would it be a reasonable option to have reviewers just use the version rendered by github? that would also display images, see for example:

https://github.com/zonca/scipy-papers-2014/blob/master/dmtcp.rst

Formatting issues on the PDF can be fixed after having accepted the submission and merged the pull request on master.

[zonca]

There might be another option:

• have a temporary repository like github.com/scipy-conference/pdf-drafts-2014, have a deploy key not encrypted for that repo, travis can build all the website and pdfs, detect which pdf is being modified in pull request, and push only the PDF there. Basically it will be a repository with all the papers in PDF format. Attacker can get repository access but not do much. Repo to be removed after papers are accepted.

[stefanv]

The question is, how do we get the papers to update when the PR gets updated?

[zonca]

That shouldn't be a problem, another commit on the PR triggers another travis-ci build, the we can push an updated PDF to the PDF drafts repo.

[stefanv]

On Mon, Mar 10, 2014 at 4:03 PM, Andrea Zonca notifications@github.comwrote:

That shouldn't be a problem, another commit on the PR triggers another travis-ci build, the we can push an updated PDF to the PDF drafts repo.

That would be perfect. We will use a clone of the scipy_proceedings repo again this year, I imagine.

Stéfan

[zonca]

So, should I test this? Need a new repository pdf-drafts-2014 or something similar with admin access.

[stefanv]

There we go:

https://github.com/scipy-conference/proc_pdf_drafts_2014

Thanks so much for all your help.

On Mon, Mar 10, 2014 at 4:11 PM, Andrea Zonca notifications@github.comwrote:

So, should I test this? Need a new repository pdf-drafts-2014 or something similar with admin access.

Reply to this email directly or view it on GitHubhttps://github.com/scipy-conference/openproceedings-buildbot-scipy/issues/1#issuecomment-37185648 .

[zonca]

ok, this works,

so, commits to master update the pelican website (html and pdf), while PRs just create a commit of the PDF draft to: https://github.com/scipy-conference/proc_pdf_drafts_2014

So reviewers can check also the PDF version before merging.

I just need another team that has only access to this repo: scipy-conference/proc_pdf_drafts_2014

so the "unsecure" bot can only publish there.

[zonca]

@stefanv if you create that team, I can add the scipy-proceedings-bot-unsecure bot there and close this issue.

[stefanv]

Done and done!

[zonca]

Thanks, this is completed, we'll do some additional testing later on.