search

scipy-conference / procbuild

SciPy proceedings builder
Other
2 stars 10 forks source link

Indices break whenever a new paper is added #19

Closed mpacer closed 6 years ago

mpacer commented 7 years ago

Because of the way indexing is handled, every time there is a new PR all the old indices break.

This is because the new PR is given the 0 index value (rather than the n index value). A simple fix would be to just organise the building in reverse.

A real fix would be to index papers by unique keys related to their identity at the time of their creation that can be trusted not to change (paper titles would not work, but user names may not be unique if more than one submission is submitted by the same author).

stefanv commented 7 years ago

How about using the GitHub PR number?

mpacer commented 6 years ago

We could use the PR number, but then it'd be better to iterate over a dictionary, which then can't guarantee the order.

I tried the reversal approach in #27 and it seems like it works.

mpacer commented 6 years ago

So I think that we should switch it to use a dict based lookup based on the PR number, but that's a bigger change than the reversal for now, so we should make that a new issue if/when we close this one.

Reasoning being: dict based indexing is a more robust system, but, technically, a nice-to-have.

stefanv commented 6 years ago

Agreed, those IDs are better.