scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
223 stars 512 forks source link

Paper: Supporting Greater Interactivity in the IPython Visualization Ecosystem #912

Open WarmCyan opened 1 month ago

WarmCyan commented 1 month ago

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Charles Lindsey @cdlindsey

Reviewers:

github-actions[bot] commented 1 month ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/nathan_martindale 🔍 Inspect 49 checks passed (20 optional) May 31, 2024, 9:07 PM
ktzhao commented 1 week ago

It is a pleasure to review your paper. I have thoroughly enjoyed reading your work and find it innovative.

The paper follows a logical flow, explaining the importance of interactive visualization, the limitations of IPyWidgets, the benefits of IPyVuetify, and finally introducing IPyOverlay as a solution. It explains IPyWidgets, IPyVuetify, and how IPyOverlay addresses their limitations. The example use case effectively illustrates the library's practical application.

However, I noticed that some sentences are a little complex and may cause confusion for some readers. Simplifying these sentences by breaking them down into smaller parts could enhance readability and ensure that your key points are communicated clearly to a wider audience.

For instance, in the Introduction section, the sentence: "This ability to interact with and visualize data plays a crucial role in many data science/analysis workflows by allowing users to manipulate and explore, thus enhancing comprehension, improving user engagement, and often providing a faster route to an intuitive understanding of the data."

Could be revised to: “Interacting with and visualizing data is crucial in many data science /analysis workflows. It allows users to manipulate and explore data, which enhances understanding, improves engagement, and often leads to a quicker intuitive grasp of the data.”

Similarly, in the IPyWidgets section: "Although there are limitations to using IPyWidgets alone, this library brings a lot of value to the scientific Python community and the data science Jupyter workflow with its ability to marry the two language ecosystems, each of which include many visualization tools and capabilities."

Could be revised to: "IPyWidgets has limitations, but it's still a valuable tool for the scientific Python community and data science Jupyter workflows. It allows us to combine two language ecosystems with many visualization tools and capabilities."

ritwit commented 6 days ago

The paper looks good to me. The writing is clear and concise. I can appreciate the utility of IPyOverlay.

I am not an expert in visualizations. But should there be more details on the implementation of the library?

There is a minor rendering issue in the caption of code 4.

cbcunc commented 2 days ago

However, I noticed that some sentences are a little complex and may cause confusion for some readers. Simplifying these sentences by breaking them down into smaller parts could enhance readability and ensure that your key points are communicated clearly to a wider audience.

@ktzhao @ritwit If you would please, add line by line suggestions per the GitHub PR review process: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request