scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
228 stars 530 forks source link

Paper: Echodataflow: Recipe-based Fisheries Acoustics Workflow Orchestration #914

Closed valentina-s closed 1 week ago

valentina-s commented 4 months ago

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Meghann Agarwal @mepa

Reviewers:

github-actions[bot] commented 4 months ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/valentina_staneva 🔍 Inspect 88 checks passed (28 optional) Sep 3, 2024, 9:47 PM
ameyxd commented 4 months ago

@valentina-s thanks for your submission! Can you update the DOIs for "echopy_2024" and "korneliussen_lsss_2006"? We can run the checks again after.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:

error_rules:
    - rule: doi-exists
      severity: ignore
      keys:
        - abc
        - def01
TahiriNadia commented 3 months ago

Hi @valentina-s,

I'm Nadia Tahiri. I will be one of the reviewers of your paper, and I will provide detailed comments and suggestions soon.

Cheers,

ameyxd commented 3 months ago

@valentina-s thanks for your submission! Can you update the DOIs for "echopy_2024" and "korneliussen_lsss_2006"? We can run the checks again after.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:


error_rules:

    - rule: doi-exists

      severity: ignore

      keys:

        - abc

        - def01

Hi @valentina-s are you skipping any valid DOIs? We have fixed issues with failing checks for valid DOIs. please check and lmk. 🙂

mepa commented 3 months ago

Hi @gol-danRuman and @TahiriNadia! In case a little extra time is needed, the initial complete review deadline has been extended to next Wednesday, July 3rd.

TahiriNadia commented 3 months ago

Dear @valentina-s, I will list my comments one by one below in detail.

The submitted article explores the application of a recipe-based approach to dataflow orchestration within the fisheries context. This methodology aims to optimize data processing workflows in fisheries research and management by leveraging advanced scientific computing techniques. The article is highly relevant, well-structured, and written with clarity.

valentina-s commented 3 months ago

Dear @valentina-s, I will list my comments one by one below in detail.

The submitted article explores the application of a recipe-based approach to dataflow orchestration within the fisheries context. This methodology aims to optimize data processing workflows in fisheries research and management by leveraging advanced scientific computing techniques. The article is highly relevant, well-structured, and written with clarity.

Thanks @TahiriNadia! I am looking forward to your comments, and will fill in missing DOI's per @ameyxd's comment.

mepa commented 3 months ago

Hi @gol-danRuman and @TahiriNadia, the Proceedings Committee has extended the initial complete review deadline to Monday, July 8th. Thanks so much for volunteering to review and we look forward to seeing your comments!

TahiriNadia commented 2 months ago

Dear @valentina-s et al.,

Thank you for the updates. Please tag me back in when the paper is ready for a re-review!

Cheers,

mepa commented 2 months ago

Hi @valentina-s, have you have a chance to look at the reviewer's comments on your paper? Just a heads up that it may take more than one iteration of review before the forthcoming final author revision deadline.

mepa commented 2 months ago

Hey @valentina-s, I will be stepping in to provide a second review for this paper. I look forward to reviewing it and will plan to post comments later this evening.

TahiriNadia commented 1 month ago

Dear @valentina-s,

Thank you for the updates. Please tag me back in when the paper is ready for a re-review!

Cheers, Nadia

TahiriNadia commented 1 month ago

Dear @valentina-s,

The error from Dask reference. 'DOI Exists: Citation does not have DOI: dask'

Best

valentina-s commented 1 month ago

@TahiriNadia Thanks for the review! I have converted the images to text snippets, corrected references, and added more explanation of the varying dimensions across deployments and the associated challenges in the end of the Motivation section. Now the checks are passing, but if some references do not look as expected let me know (should I leave the ones with n. d. as is?).

valentina-s commented 3 weeks ago

Thanks @mepa for the review. I have addressed your comments.

mepa commented 2 weeks ago

@valentina-s, thanks for making those updates.

Though I did not get the chance to run echodataflow and potentially provide further feedback before the author revision deadline, I read the paper over again and do feel it is ready for inclusion in the Proceedings.

mepa commented 2 weeks ago

@TahiriNadia, thanks very much for reviewing! Do you approve this paper for inclusion in the Proceedings?