scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
228 stars 530 forks source link

Paper: Mamba Models a replacement for Transformers? #917

Closed JaynouOliver closed 1 week ago

JaynouOliver commented 4 months ago

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Meghann Agarwal @mepa

Reviewers:

JaynouOliver commented 4 months ago

@hongsupshin is there any specific mistake from our side which led to curvenote checks getting skipped? Can't see the deployment preview.

tkoyama010 commented 3 months ago

Hi. Thanks for invitation. I will review this paper :)

HaoZeke commented 3 months ago

As per the email received yesterday from the Proc. Comm. I am happy to review this submission.

github-actions[bot] commented 3 months ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/Suvrakamal_Das 🔍 Inspect 46 checks passed (6 optional) Jul 14, 2024, 4:41 PM
JaynouOliver commented 3 months ago

Hi, @tkoyama010 @HaoZeke just wanted to know if there are any updates regarding the review, if I do have to make any changes from here.

JaynouOliver commented 3 months ago

I can share the code written originally by the authors of MAMBA https://github.com/state-spaces/mamba Just wanted to check with you before I finally commit the changes

tkoyama010 commented 3 months ago

Thanks, I was making that statement based on the fact that SciPy papers often emphasize being able to run the code and reproduce it. Do I need to run both Transformer and mamba to understand the results of this paper?

I think this paper could be an excellent introduction to mamba. To that end, I think it would be good to add a link to it appropriately (including Transformers) :)

JaynouOliver commented 3 months ago

Sure I can add those links in the paper. I will make these changes right away.

JaynouOliver commented 3 months ago

@tkoyama010 please add any further changes if needed after review.

mepa commented 3 months ago

Hi @tkoyama010 and @HaoZeke! In case a little extra time is needed, the initial complete review deadline has been extended to next Wednesday, July 3rd.

tkoyama010 commented 3 months ago

Hi @tkoyama010 and @HaoZeke! In case a little extra time is needed, the initial complete review deadline has been extended to next Wednesday, July 3rd.

Yes please. Thanks!

JaynouOliver commented 3 months ago

@tkoyama010 please add any further changes if needed after review.

Hi @tkoyama010, all working and good!

JaynouOliver commented 2 months ago

Hi everyone @tkoyama010 @HaoZeke @ameyxd @mepa ,

I hope you’re all doing well. If there are any additional suggestions, feedback, or corrections needed before the author revision period ends on August 7th, please let me know. I’d be happy to make the necessary changes and incorporate your feedback.

Thank you very much!

mepa commented 1 month ago

Hi @tkoyama010 and @HaoZeke - Do you feel that this paper is ready for inclusion in the Proceedings?

@tkoyama010, I see that you have approved the PR so will assume "yes" unless I hear otherwise.

Thanks for reviewing!

tkoyama010 commented 1 month ago

Yes! I am ready for it.

HaoZeke commented 1 month ago

LGTM as well; go ahead :)

On 9/2/24 2:49 PM, Tetsuo Koyama @.***> wrote:

Yes! I am ready for it.

— Reply to this email directly, view it on GitHub https://github.com/scipy-conference/scipy_proceedings/pull/917#issuecomment-2324918474, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBCUTZJ4J6M74DRK7J7IWTZUR3GNAVCNFSM6AAAAABITCUAZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUHEYTQNBXGQ. You are receiving this because you were mentioned.Message ID: @.***>

JaynouOliver commented 1 month ago

Thanks a lot @tkoyama010 and @HaoZeke for the approval!!

mepa commented 1 month ago

Thanks very much for reviewing, @tkoyama010 and @HaoZeke.