search

scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
223 stars 512 forks source link

Paper: THEIA: An Offline Tool for Tradespace Visualization #920

Open samuelcwilliams opened 1 month ago

samuelcwilliams commented 1 month ago

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Hongsup Shin @hongsupshin

Reviewers:

stevejpurves commented 1 month ago

@samuelcwilliams the id field in your myst.yml needs to conform exactly to the pattern scipy-2024-<folder>

github-actions[bot] commented 1 month ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/theia 🔍 Inspect ✅ 37 checks passed (7 optional) Jul 14, 2024, 6:20 PM
ameyxd commented 1 month ago

@samuelcwilliams thanks for the submission! Can you add the DOI for plotly? We can run the checks again after.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:

error_rules:
    - rule: doi-exists
      severity: ignore
      keys:
        - abc
        - def01
samuelcwilliams commented 1 month ago

@ameyxd, I followed Plotly citation guidance found here, and it didn't include a DOI, so I set it to ignore.

ameyxd commented 1 month ago

thanks @samuelcwilliams cheers.

mihaimaruseac commented 3 weeks ago

Overall, this looks good, but I think it would be even more useful if you can show how the data listed at the beginning of the paper is processed to produce the screenshots at the end. Does the user have to type code? If yes, can you include the code? If not, can you then show how this will work with a more complex data type?

samuelcwilliams commented 3 weeks ago

@mihaimaruseac I made some small changes and added in some new content regarding the data upload process and the details on the screenshots in the paper. Let me know if you think there are any areas I should expand on. I appreciate all the feedback!

tkoyama010 commented 1 day ago

I'm sorry, I closed the PR by mistake.

tkoyama010 commented 23 hours ago

Thank you. The logic of this paper itself seems perfect to me. I just didn't quite understand background what Tradespace meant. I would like you to explain in more detail what kind of data you are trying to process.

@cbcunc I already finished review :)