search

scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
228 stars 530 forks source link

Paper: ITK-Wasm Universal spatial analysis and visualization #927

Closed thewtex closed 1 week ago

thewtex commented 4 months ago

Editor: Sanhita Joshi @sanhitamj

Reviewers:

github-actions[bot] commented 4 months ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/matt_mccormick 🔍 Inspect ❌ 107/108 checks passed (9 optional) Sep 2, 2024, 7:33 PM
thewtex commented 3 months ago

@amjames thank you for the review! I agree with your comments and will follow-up accordingly.

sanhitamj commented 1 month ago

Hi @thewtex, 2nd Sept is the final deadline to make any edits to the manuscript.

thewtex commented 1 month ago

@stevejpurves we could forgo the renderer plugin until it is more mature and just use a figure and iframe directive as you suggested. But how do I use the placeholder + figure + iframe so we do not get the placeholder rendered in HTML?

I currently get:

image

with:

::::{figure} :label: fig:vm_head_frozenct_ome_zarr :placeholder: figures/vm-head-frozenct-ome-zarr-snapshot.png

Visible Male frozen head computed tomography (CT) OME-Zarr volume, generated and visualized with ITK-Wasm. There are three resolution scales, which can be selected with the Image Scale buttons. Reduced resolutions are smoothed with a gaussian filter to avoid aliasing artifacts.

:::{iframe} https://scipy-2024-itk-wasm-vm-head-frozenct-ome-zarr.netlify.app/ :width: 100% :::

::::

thewtex commented 1 month ago

@stevejpurves @rowanc1 how do we make figure placeholder images (PDF generation) work with iframes?

rowanc1 commented 1 month ago

If you can include the image you would like and a comment above the iframe in the markdown, we will take care of it at publication time.

sanhitamj commented 1 month ago

Hi @thewtex thanks for the submission and the subsequent edits to the paper. Tomorrow, 2nd Sept is the last day for author edits.

Hi @amjames thank you for helping with reviewing the paper. Will you please share your final decision about the paper by 9th Sept?

thewtex commented 1 month ago

If you can include the image you would like and a comment above the iframe in the markdown, we will take care of it at publication time.

@rowanc1 thanks! I commented out the placeholder images in https://github.com/scipy-conference/scipy_proceedings/pull/927/commits/044dd4a300c78728c6421d1fc780336045d827eb

Has the SciPy Proceeding MyST theme been made available? I think this would follow the SciPy Conference's FLOSS values. And it would enable folks like myself to look into issues like this when encountered.

Hi @thewtex thanks for the submission and the subsequent edits to the paper. Tomorrow, 2nd Sept is the last day for author edits.

@sanhitamj thanks for the guidance and help editing! I have pushed all edits.

@amjames thanks again for the review. I tried to address all of your comments.