search

scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
223 stars 512 forks source link

Paper: geosnap: The Geospatial Neighborhood Analysis Package #931

Open knaaptime opened 1 month ago

knaaptime commented 1 month ago

Editor: Amey Ambade @ameyxd

Reviewers:

github-actions[bot] commented 1 month ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/eli_knaap 🔍 Inspect ✅ 80 checks passed (7 optional) Jun 12, 2024, 8:20 PM
hongsupshin commented 1 month ago

@knaaptime Hi Eli, could you update the PR name so that it reflects the title of the paper? This would avoid any confusion during the review process. Thanks!

knaaptime commented 1 month ago

sorry, yes! making some updates shortly

ameyxd commented 1 month ago

@knaaptime can you update the DOIs and link that fail checks?

knaaptime commented 1 month ago

yes! I also need to add several abbreviations to the yaml. Can I add a wip tag for a day or two?

ameyxd commented 1 month ago

@knaaptime issue here also affects your paper. We are working on a fix.

ameyxd commented 1 month ago

@knaaptime there are some citations that do not have DOIs. can you recheck the DOIs that fail checks? As long as they are valid DOIs we should be okay.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:


  - rule: doi-exists
    severity: ignore
    keys:
      - abc
      - def01
knaaptime commented 1 month ago

pushed a fix for two articles that are missing. Not sure whats up with he rest of those 'doi fail to resolve' errors. If you click the link shown in the CI it will take you right to the article

rowanc1 commented 1 month ago

Hi @knaaptime -- we are having some issues with doi.org at the moment (see #935), we should have this fixed by the end of the week. Thank you for adding DOIs, we will get the other checks passing soon!

fwkoch commented 1 month ago

Thanks for merging that suggestion - the previous failure is now fixed. The new failure is back to another, different DOI issue on the checks 🙁. Fixing it up now, nothing more for you to worry about 🙂.

ameyxd commented 3 weeks ago

Review requests sent to @shuangw1 and @shahnawaz323

ameyxd commented 1 week ago

Resent email requests for review to @shuangw1 and @shahnawaz323

shuangw1 commented 1 week ago

Hello organizers, I have emailed before because of health issues I am not able to do review. Please assign the tasks to someone else. Thanks, Shuang

在 2024年7月3日，01:22，Amey Ambade @.***> 写道：



Resent email requests for review to @shuangw1https://github.com/shuangw1 and @shahnawaz323https://github.com/shahnawaz323

— Reply to this email directly, view it on GitHubhttps://github.com/scipy-conference/scipy_proceedings/pull/931#issuecomment-2203892221, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOUMVJKJGVCQRNCN4IVAR5TZKLOVFAVCNFSM6AAAAABIT22F3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTHA4TEMRSGE. You are receiving this because you were mentioned.Message ID: @.***>