Closed amakelov closed 1 week ago
Curvenote Preview
Directory | Preview | Checks | Updated (UTC) |
---|---|---|---|
papers/aleksandar_makelov | 🔍 Inspect | ✅ 33 checks passed (6 optional) | Jul 14, 2024, 3:49 PM |
@amakelov can you recheck the DOIs that fail checks? As long as they are valid DOIs we should be okay.
you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:
- rule: doi-exists
severity: ignore
keys:
- abc
- def01
Hey @amakelov are you skipping DOIs when they exist? I don't recommend skipping explicitly just because they are failing checks. Please lmk
Hi @ameyxd, I only skipped the DOIs for papers/other publications where I couldn't find a DOI after searching on crossref.
okay. can you add your ORCiD and affiliation? :)
OK, this failed again - I guess I didn't follow the latex instructions? Is it correct that I must remove everything before and including \begin{document}?
I think removing everything before and including \begin{document}
would also be fine - that will remove any other conflicting metadata.
Is there anything in there you are concerned about losing? Some of the newcommand
stuff might need to come into myst.yml
project.math
. There are a number of errors in your preview build, linked in the comment at the top of your PR (e.g. cross-references). Once the affiliation check is passing, I'll take a deeper look there...
:wave: Hi @amakelov. I will be one of your reviewers for your SciPy 2024 proceedings submission. You should expect a full first pass review from me in the form of a PR review with comments and suggestions before 2024-06-29. Please tag me here with any comments you have for me. :+1:
Hi @amakelov! I will also be reviewing your paper, alongside @matthewfeickert . Looking forward to reading it!
Review reminders sent to @matthewfeickert and @apaleyes
@amakelov looks like you've put quite a lot of work into updating the paper. Thanks! Do you think it is ready for another pass, or not yet?
@amakelov looks like you've put quite a lot of work into updating the paper. Thanks! Do you think it is ready for another pass, or not yet?
@apaleyes indeed, the current version incorporates all the feedback as far as I'm aware - so it's a great time for another pass!
In the meantime, in case anybody is interested, I've also greatly updated the documentation of the library in preparation for a next release:
In particular, the "Caveats" notebook contains some of the things we discussed here: https://amakelov.github.io/mandala/tutorials/gotchas/
@apaleyes, @matthewfeickert - can you confirm your feedback has been incorporated by the author and give me a thumbs up.
@ameyxd yes, I am happy with the changes. Great job on the paper @amakelov , thanks for the insightful discussions!
Congratulations @amakelov on having your paper accepted and merged! :rocket: Nice work. :)
If you are creating this PR in order to submit a draft of your paper, please name your PR with
Paper: <title>
. An editor will then add apaper
label and GitHub Actions will be run to check and build your paper.See the project readme for more information.
Editor: Amey Ambade @ameyxd
Reviewers: Andrei Paleyes @apaleyes and Matthew Feickert @matthewfeickert