search

scipy-conference / scipy_proceedings

Tools used to generate the SciPy conference proceedings
Other
223 stars 512 forks source link

Paper: multinterp: A Unified Interface for Multivariate Interpolation in the Scientific Python Ecosystem #937

Open alanlujan91 opened 1 month ago

alanlujan91 commented 1 month ago

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Amey Ambade @ameyxd

Reviewers:

github-actions[bot] commented 1 month ago

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/alan_lujan 🔍 Inspect ✅ 29 checks passed (6 optional) Jun 12, 2024, 5:19 PM
ameyxd commented 1 month ago

@alanlujan91 can you recheck the DOIs that fail checks? As long as they are valid DOIs we should be okay.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:


  - rule: doi-exists
    severity: ignore
    keys:
      - abc
      - def01
ameyxd commented 1 month ago

@alanlujan91 are you skipping valid DOIs? If so, please refrain and try the checks again. 😅

alanlujan91 commented 1 month ago

@ameyxd I believe the ones I'm skipping don't have DOIs. I can try to look again

ameyxd commented 1 month ago

Okay! please check "Paszke2019" in particular. lmk when complete and passing checks.

alanlujan91 commented 1 month ago

@ameyxd Oh I remember what happened.

I found https://dl.acm.org/doi/10.5555/3454287.3455008 so I put that on my bib, then pushed, but mystmd didn't like the doi, probably because of this

image

so then I set to ignore, but mystmd still didn't like it, so I removed it altogether from the bib @rowanc1 any advice?

ameyxd commented 3 weeks ago

Review reminders sent to @gcdeshpande and @aparoha

cbcunc commented 3 weeks ago

so then I set to ignore, but mystmd still didn't like it, so I removed it altogether from the bib @rowanc1 any advice?

@rowanc1 Any comment?

rowanc1 commented 2 weeks ago

Hi @alanlujan91 - we talked about this today in our editorial team meeting and would love to showcase your article with computational capabilities and reproducibility (as per this note in the readme!).

I think following the review comment by @aparoha "some sections seem to repeat concepts without introducing new information or advancing the narrative.", it looks as though you are including the full notebooks, rather than individual cells. There is a way in MyST to include individual cells or outputs that keep links to the original location of the supporting materials. The documentation is here. That could be a way to change how you are showcasing the information and better highlight and link to your supporting materials.

If you are open to it I would love to work on you to change the use of MyST slightly to better highlight the computational aspects. Let me know if you have time this week or next week?

alanlujan91 commented 2 weeks ago

@rowanc1 that would be great!

I am at a conference this week, so I haven't had time to address the previous comments, but will be available next week to discuss how we can improve this work

rowanc1 commented 2 weeks ago

Fantastic - I will reach out to you separately and get a meeting scheduled soon. Very very excited to show off your content in the SciPy Proceedings this year, and elevate the use of Jupyter Notebooks and reproducibility. 🚀