search

scipy-conference / scipy_proceedings_2012

2012 SciPy conference proceedings
Other
3 stars 11 forks source link

johansson: qtip paper review #15

Closed stefanv closed 10 years ago

stefanv commented 10 years ago

Disclosure: I am not an expert in quantum mechanics or simulation.

This paper is perfectly suited to publication in the proceedings. It gives a concise and well-written exposition of the QuTip library for quantum simulation.

I only have some minor editorial feedback:

Link to http://qutip.org/ early in the paper (abstract, introduction?) "as oppose to" -> "as opposed to" "The main challenge in numerical simulation of quantum system" -> systems? "as oppose of wavefunctions" ? "open quantum system" -> "open quantum systems" "provides are: tensor, ....; ptrace, ..." (commas and semi-colons)" "packages for python" -> "packages for Python" "various time-evolutions solvers. We" -> "various time-evolution solvers, we" Last page: "without for example" -> "without, for example" spaces between paragraphs use -> uses Capitalize python -> Python (several instances) "accessible through a superior" --> what does "superior" imply?

stefanv commented 10 years ago

/cc @jrjohansson

jrjohansson commented 10 years ago

Thanks for the feedback! I've addressed these issues in PR #23

stefanv commented 10 years ago

Thanks, I've merged your changes--good to go!