Open safl opened 10 years ago
Thanks!
On Tue, Jul 29, 2014 at 7:53 PM, Simon A. F. Lund notifications@github.com wrote:
Thank you for taking your time to review the paper.
I have revised the paper based on the marked-up pdf.
It is worth mentioning:
Some aspects of the cphVB project is no longer valid, the most essential is the existence of the project since cphVB is deprecated, the efforts are
continued in the Bohrium project.
You can merge this Pull Request by running
git pull https://github.com/safl/scipy_proceedings_2012 master
Or view, comment on, or merge it at:
https://github.com/scipy-conference/scipy_proceedings_2012/pull/28 Commit Summary
- papers/simon_lund: Revised based on reviewer feedback.
File Changes
- M papers/simon_lund/simon_lund.rst https://github.com/scipy-conference/scipy_proceedings_2012/pull/28/files#diff-0 (102)
Patch Links:
- https://github.com/scipy-conference/scipy_proceedings_2012/pull/28.patch
https://github.com/scipy-conference/scipy_proceedings_2012/pull/28.diff
— Reply to this email directly or view it on GitHub https://github.com/scipy-conference/scipy_proceedings_2012/pull/28.
@safl, I will make sure to take a look at your changes and make sure to take into account the difficultly involved with a project that has been deprecated in the intervening years. I will try to have some comments soon so stayed tuned.
I finally got around to re-reading the paper today (sorry that took so long). Many of the structural issues have been resolved to my satisfaction. I think the primary issue is still the lack of details in the performance comparison but this is understandable given that the project has been deprecated. I think it might still be nice if you explain what the vector-engines "simple", "score" and "mcore" are in more detail.
I have added a brief description of the vector engines. Does it suffice? I find that it will be out of scope to describe the implementation in greater detail.
Thanks, that helps a lot (I would not have guessed that was what you were doing). +1
Excellent.
Thank you for taking your time to review the paper.
I have revised the paper based on the marked-up pdf.
It is worth mentioning:
Some aspects of the cphVB project is no longer valid, the most essential is the existence of the project since cphVB is deprecated, the efforts are continued in the Bohrium project.