Open mandli opened 10 years ago
Thanks for reviewing @mandli - I'll see if I can't sneak in an oppurtunity to fix these (though the likelihood is low.)
If you have any questions let me know.
Yes, although I think a slight modification to make the CLI examples a bit more readable would be helpful (just use $> or something).
So the reason that I did not do this was to express clearly that flmake functions outside of the flash code directories explicitly. This is an important point not to be overlooked by users of flmake.
Review of "Total Recall: flmake and the Quest for Reproducibility"
Reviewer: Kyle Mandli Department: Institute for Computational Engineering and Science Institution: University of Texas at Austin Field: Applied and Computational Mathematics Country: USA Article Reviewed: Total Recall: flmake and the Quest for Reproducibility
General Evaluation
below doesn't meet standards for academic publication meets meets or exceeds the standards for academic publication n/a not applicable
Quality of the approach:
Quality of the writing:
Quality of the figures/tables:
Is the code made publicly available and does the article sufficiently describe how to access it?
Does the article present the problem in an appropriate context? Specifically, does it:
Is the content of the paper accessible to a computational scientist with no specific knowledge in the given field?
Does the paper describe a well-formulated scientific or technical achievement?
Are the technical and scientific decisions well-motivated and clearly explained?
Are the code examples (if any) sound, clear, and well-written?
Is the paper factual correct?
Is the language and grammar of sufficient quality?
Are the conclusions justified?
Is prior work properly and fully cited?
Should any part of the article be shortened or expanded? Please explain.
In your view, is the paper fit for publication in the conference proceedings? Please suggest specific improvements and indicate whether you think the article needs a significant rewrite (rather than a minor revision).