search

scipy-conference / scipy_proceedings_2012

2012 SciPy conference proceedings
Other
3 stars 11 forks source link

minor copy-editing for adam_hughes #7

Closed minrk closed 10 years ago

minrk commented 10 years ago

minor edits per review in #8

ahmadia commented 10 years ago

A couple of text-wraps with no changes, but this looks good to merge in. @hugadams / @stefanv?

minrk commented 10 years ago

A couple of text-wraps with no changes

I don't think I re-wrapped anything. I think GitHub doesn't do word-diffs if the diff is late enough on very long lines (see the crazy behavior of Python's difflib for long lines for a possible reason).

ahmadia commented 10 years ago

Ergg, my eyeball-diffing is insufficient to catch the differences, I may need to go back and look at the issues. Thanks for the edits @minrk :)

stefanv commented 10 years ago

Looks good to me!

hughesadam87 commented 10 years ago

At this point, can I work directly with the .tex, or do I need to stick with the .rst script? Sorry for late reply, had wrong email set on github

ahmadia commented 10 years ago

@stefanv?

hughesadam87 commented 10 years ago

Actually, I see that the .rst file is the one that's stored on the repo. Let me look into the figures quickly. If I do replace the figures, is the best way to just push changes or send them to someone specifically?

stefanv commented 10 years ago

Please work on the .rst file.

hughesadam87 commented 10 years ago

Ok, well sorry I'm late to the discussion. I can update some of the graphs actually; we've extended these capabilites a great deal, but don't want to delay this process too much longer. I got an email from Aron asking to have this finalized by July 4th. I can get it done before then. What would be the easiest way to update the figures? IE which repo should I branch from and make changes so that they are easy for you guys to intercept?

ahmadia commented 10 years ago

Branch from this one and submit a PR back here, if that works for you.

ahmadia commented 10 years ago

While I have your attention, are you okay with merging these edits @hugadams?

hughesadam87 commented 10 years ago

Thanks. Ya, totally cool.

ahmadia commented 10 years ago

Thanks @minrk

hughesadam87 commented 10 years ago

Hey guys,

Turns out I lost some of the data from the original experiments that were used to generate the plots that I was going to update. I know it's not very aesthetically pleasing, but any problem if we just leave the figures as is? Sorry.

ahmadia commented 10 years ago

This paper is accepted.

hughesadam87 commented 10 years ago

Thanks! Also, thanks for working on this even in 2014 On Aug 3, 2014 12:38 PM, "Aron Ahmadia" notifications@github.com wrote:

This paper is accepted.

— Reply to this email directly or view it on GitHub https://github.com/scipy-conference/scipy_proceedings_2012/pull/7#issuecomment-50995283 .