scipy / SciPyCentral

SciPy Central
http://scipy-central.org
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Minor fixes #115

Closed pv closed 11 years ago

pv commented 12 years ago

Three unrelated minor fixups:

Note that scipy_central/submission/templates/submission/email_website_admin.txt is missing from the repository at the moment.

pv commented 11 years ago

@kgdunn: ping? Probably at least 22232f8 should go in?

ksurya commented 11 years ago

@pv I even found this bug when working on new design. I added an empty txt file with respective name. I guess with the new design pull-request, this will be done.

pv commented 11 years ago

Rebased on top of master. Copying the sphinx-conf.py doesn't seem to be needed anymore, so dropped that change.

@ksurya: the EOFError is perhaps unrelated to this --- is it the one you fixed it in 03a492f ? Could you check whether this PR works for you?

ksurya commented 11 years ago

https://github.com/ksurya/SciPyCentral/commit/0ec0d58f2ffde5b1040c0411b3bfe2c2f4cd766a This was the bug you mentioned in this PR notes I fixed.. I will check this PR and comment soon

pv commented 11 years ago

Ok, fixed now the sphinx-conf.py copying in a different way. Now it seems to work.

Also, spotted several bugs in the DVCS wrapper, which prevented adding new snippets, namely adcafb7. I wonder if it worked previously at all?

I'll go ahead and merge, unless there are some futher comments.

pv commented 11 years ago

So it seems. However, it's obvious from the code that the argument to .add() should be a list.

pv commented 11 years ago

I'll rebase and split this to separate parts.