search

scipy / SciPyCentral

SciPy Central
http://scipy-central.org
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Design 1.0 #118

Closed ksurya closed 11 years ago

ksurya commented 11 years ago

Changes:

  1. Developed new design from scratch using Twitter Bootstrap
  2. Bug Fix: scipy_central/submission/templates/submission/email_website_admin.txt is added (also mentioned by pv in his PR: https://github.com/scipy/SciPyCentral/pull/115) --TemplateDoesNotExist exception raised
  3. Bug Fix at /rest_comments/views.py ln: 235 -- EOFError

Website Main page preview:

spc-main-page-preview

pv commented 11 years ago

+1 looks good to me. Unless further comments, I'll proceed to merging this in the next few days.

One question: the font sizes seem to be in pixels --- how does this work for monitors with high resolution? Does bootstrap do something smart with this?

ksurya commented 11 years ago

This pixels vs em discussion is going on from ages. I don't know but Bootstrap somehow thought to use pixels for font sizes. Yeah, I guess, using ems makes site more responsive but I don't think its totally bad to use pixels either.

There are lots of discussions in forums about this issue.. this is one of them: http://stackoverflow.com/q/12999267/1162468

To our site in specific, I don't think its a problem.

pv commented 11 years ago

Well, I guess if it's good enough for twitter, it's good enough for us...

ksurya commented 11 years ago

There is always scope for improving. The current design uses LESS. I can definitely tell you that, changing to relative font sizes is just not more than 2-3 lines of code (approx).

Once we go live, we can actually get lots of input from various people using it and we can take it from there. What do you say?

Specifically, before merging, it would be great if you take a look at this commit carefully: https://github.com/ksurya/SciPyCentral/commit/03a492f907a983db085c0940a3060e62d309e70f

pv commented 11 years ago

03a492f is correct, it should be in binary mode.

pv commented 11 years ago

Merged, thanks!