search

scipy / SciPyCentral

SciPy Central
http://scipy-central.org
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Use django paginator #141

Closed ksurya closed 10 years ago

ksurya commented 10 years ago

The below are some improvements in the code

  1. Use paginator class for finding next and previous objects
ksurya commented 10 years ago

Note: Tested DVCSError bug fix on Linux environment, and its working

lomegor commented 10 years ago

Split this PR into several PRs, each of them a different fix or enhancement. Also, you an remove the DoNotMerge from this one, since if they pass review they will be ready to merge.

lomegor commented 10 years ago

Split this PR into two. There a problem with the paginator I believe. Create a lot of submissions and revisions, and click a lot of times in previous and you get into an error page.

ksurya commented 10 years ago

Oh! I will test it and let you know

ksurya commented 10 years ago

I have created 50 submissions using the test scripts written previously. I tried the previous and next links and they seem to work. Since we use same test data in db, could you please give me the url where you are finding this error?

lomegor commented 10 years ago

Ok, thanks! It's possible that the error I had was with the database (maybe something to do with testing the other branches, and the problem with uploading ZIP files). I recreated the db and I don't get the same error. If Pauli can't reproduce it either, I think this is ready to merge.