search

scipy / SciPyCentral

SciPy Central
http://scipy-central.org
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

BUG: fix wrong usage of os.path.normpath #144

Closed ksurya closed 10 years ago

ksurya commented 10 years ago

Its wrong usage of method. probably a typo. Was brought from commit https://github.com/scipy/SciPyCentral/commit/1601a025072e375d288ce561904ffa5aaca7bc84

lomegor commented 10 years ago

Is this supposed to fix the image upload issue? I'm still getting: "Error on server, please try again decoder jpeg not available". There are two things to fix here: whatever is causing the error, and whatever is in the frontend that is showing that error. Also, after I selected an image there's no indication in the button that I have done so; was this always like this? It should probably say the file name as with the normal file selector.

ksurya commented 10 years ago

Its working on my system. I think there might be a problem with PIL. Please take a look into scipy_central/screenshot/settings.py , models.py. Its where PIL imports are used and take a look whether those imports are working exactly in your system ..

Regarding showing filename, I am looking into the code now, and let you know about it

lomegor commented 10 years ago

I'm going to see if PIL is working, but you should be also looking into improving the error shown; it shouldn't be saying "decode jpg not available"; just "please try again".

lomegor commented 10 years ago

Why are we using PIL? If I just do import Image, it's working correctly. I'm not sure why PIL doesn't work for me; probably a missing linked library or something. Can we not use PIL?

ksurya commented 10 years ago

The site stores original file along with scaled-down version too. For that, we need it.

lomegor commented 10 years ago

Can you please investigate if that can't be done without PIL? Because I think it's working for me, and it would be best to remove one unnecessary dependency.

ksurya commented 10 years ago

@lomegor We are using PIL to primarily modify uploaded image. In our case, right now, we are majorly using it to modify the size of image incase its big.

There are good chances that we can remove the usage and find other solutions. However, I can't say for sure.

lomegor commented 10 years ago

+1 to merge if it's working. I can't test because of that error.