Closed rgommers closed 3 years ago
@rgommers The issue here is that the initial Boost 1.75.0 commit was not generated using the make_headers.sh
script, that came afterwards to improve reproducibility (and rightfully so as I don't remember exactly what I did to produce the initial commit contents).
I'm happy to have the history rewritten to include what you have generated for 1.75.0 (might also involve updating the Boost submodule commit in SciPy if the commit hash changes), but I don't foresee us needing to change anything in this repo until SciPy moves its minimum GCC version above 7.1 (needed to avoid a compiler bug preventing Boost 1.76.0 header files from building as noted here). Unless you want to rewrite the history, I don't know if there's anything actionable to do except leave these notes for future us when we think about upgrading our Boost dependency
That all makes sense. I think we can leave it as is, no need to rewrite history. I just wanted to capture it in case we have to come back to this in the future. Let's just close this issue.
This doesn't seem like a real problem, because the difference is only files that were removed and we're not using those in SciPy I think. That said, running the automated script doesn't reproduce the initial commit in this repo, so I thought it'd be useful to record the files with differences:
Full diff:
It's not impossible I messed something up here. What I did is:
master
make_headers.sh
back to1.75.0
make_headers.sh
script)