ENH: Boost 1.75 and patch application

scipy / boost-headers-only

Boost header directory.

Boost Software License 1.0

19 stars 16 forks source link

ENH: Boost 1.75 and patch application #6

Closed mckib2 closed 2 years ago

mckib2 commented 2 years ago

In support of #5

"revert" main such that it has the same version of Boost used by SciPy
- SciPy is built against Boost 1.75, but this repo's main contains Boost 1.76
- It would be nice for the default GitHub view (main branch at latest commit) to match the Boost version and contents being built in SciPy
- The majority of the diffs in this PR are reverting from Boost 1.76 to Boost 1.75
add mechanism to automatically apply patches during header generation

mckib2 commented 2 years ago

@rgommers Probably more useful to browse by commit for this PR -- changes mostly concentrated in generated Boost header files. The last commit has the interesting bits

mckib2 commented 2 years ago

@rgommers Sorry, I missed your last comment. I updated PR description -- does that make it more clear why/where those diffs come from?

rgommers commented 2 years ago

Thanks @mckib2, only kind of - I am still puzzled about why we have commits in main here that we never pointed the SciPy Boost submodule at. Were they just for testing? If so, and you're happy to discard that now, then yes I think we can go ahead and merge this.

mckib2 commented 2 years ago

Were they just for testing?

My recollection is hazy, but yes, I believe before we moved the boost-headers-only repo under the SciPy org I had made a commit to main to test out if Boost 1.76 worked with SciPy. It did not, but looks like I never reverted that commit so it's been there this whole time

rgommers commented 2 years ago

Okay thanks, in it goes!