scipy / oldest-supported-numpy

Meta-package providing the oldest supported Numpy for a given Python version and platform
BSD 2-Clause "Simplified" License
55 stars 33 forks source link

Issue with oldest-supported-numpy package approach and pip 22.1 build validation with `--no-build-isolation` #53

Closed lesteve closed 2 years ago

lesteve commented 2 years ago

Any suggestions on how to handle the situation nicely would be more than welcome! As a short-term fix, we have pinned pip to 22.0.4.

To reproduce with scikit-learn:

mamba create -n test cython scipy 'setuptools<60' -y
git clone https://github.com/scikit-learn/scikit-learn
cd scikit-learn
pip install --no-build-isolation .

Error

ERROR: Some build dependencies for file:///home/local/lesteve/dev/scikit-learn are missing: 'oldest-supported-numpy'.
rgommers commented 2 years ago

Argh! Thanks for the report @lesteve. That seems like a clear oversight in the Pip PR that introduced this behavior. A pin sounds right as a workaround, I'll go ask for a fix in Pip itself.

lesteve commented 2 years ago

pip 22.1.1 has been released with the fix from https://github.com/pypa/pip/commit/30af8074bf83d41a9dacdcd13fb6ca982856032d. Closing this one, thanks a lot for reporting the issue in the pip issue tracker!